Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMM liquidity pool support #3908

Open
yxxyun opened this issue Aug 20, 2021 · 4 comments
Open

Add AMM liquidity pool support #3908

yxxyun opened this issue Aug 20, 2021 · 4 comments
Labels
Feature Request Used to indicate requests to add new features

Comments

@yxxyun
Copy link

yxxyun commented Aug 20, 2021

Summary

Add AMM liquidity pool to enchance XRPL DEX

Motivation

It's hard to provide liquidity on current XRPL DEX, and some liquidity bots generate a lot noise offercreate and offercancel txs, this can be solved by AMM LP.

Solution

Add AMM liquidity pool object can be deposit and withdraw, and update offercreate and path payment to try both liquidity pools and the order books.

Paths Not Taken

Implement account based AMM LP via Hooks( Smart contract), but this can't trade against with offercreate and path payment.

@yxxyun yxxyun added the Feature Request Used to indicate requests to add new features label Aug 20, 2021
@StevieSimple
Copy link

Good point I hope Ripple will do something to address a glaring shortfall? Peace Out Unity through Prosperity! LFBF TYHP

@yxxyun
Copy link
Author

yxxyun commented Aug 29, 2021

@nbougalis
Copy link
Contributor

@yxxyun: The C++ team at Ripple is working on an AMM proposal, which is something we've stated before.


With that said, let me take the opportunity to address something else. @firefly3582 wrote

This has been suggested many times over the years by different developers, but it seems like Ripple doesn't want to implement such thing, I don't know why.

I don't quite understand why it matters what Ripple does and doesn't want to implement. Anyone can propose changes and contribute code to effectuate those changes.

So, perhaps instead of waiting for Ripple to build X, whatever that X might be, how about writing up a spec and then implementing it instead?

@tequdev
Copy link
Contributor

tequdev commented Sep 24, 2022

AMM implementation is proposed here.

#4294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

5 participants
@yxxyun @nbougalis @tequdev @StevieSimple and others