Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete owner_info API method #4594

Open
mDuo13 opened this issue Jun 28, 2023 · 0 comments
Open

Remove obsolete owner_info API method #4594

mDuo13 opened this issue Jun 28, 2023 · 0 comments
Assignees
Labels
API Change APIv3 Change does not take effect unless client opts-in to api_version 3 (currently beta) Tech Debt Non-urgent improvements

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Jun 28, 2023

The owner_info command is an obsolete equivalent to account_objects. (#4404 was the first code change to touch it in ~8 years.) It's undocumented (other than the Public API Methods page saying to not use it).

Unlike account_objects, which supports pagination, ledger selection, filtering, and all types of ledger entries, owner_info only returns lists of Offers and trust lines in the "current" and "accepted" ledgers. (The "accepted" ledger is kind of a legacy equivalent to the "validated" ledger; I'm unclear if there's actually a distinction under the covers.)

I believe you can call this method on p2p nodes from commandline, JSON-RPC, or WebSocket. Clio does not implement this method. I'm unsure about Reporting Mode.

There's no good reason to use owner_info, and I doubt there are any clients actively using it effectively, so we should remove it entirely.

Main source file: https://github.com/XRPLF/rippled/blob/master/src/ripple/rpc/handlers/OwnerInfo.cpp

@mDuo13 mDuo13 added API Change Tech Debt Non-urgent improvements labels Jun 28, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Core Ledger Jun 30, 2023
@Bronek Bronek added the APIv3 Change does not take effect unless client opts-in to api_version 3 (currently beta) label Feb 27, 2024
@Bronek Bronek self-assigned this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change APIv3 Change does not take effect unless client opts-in to api_version 3 (currently beta) Tech Debt Non-urgent improvements
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants