From d9f1141266b4ec6b31ea1e640a39013e6e942a03 Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Tue, 3 Oct 2023 14:07:25 -0400 Subject: [PATCH 1/3] Note that `fee_ref` will be removed if XRPFees is enabled --- .../public-api-methods/subscription-methods/subscribe.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md b/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md index ca978f6618c..f14b5525505 100644 --- a/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md +++ b/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md @@ -169,7 +169,7 @@ The fields from a ledger stream message are as follows: |:--------------------|:--------------------------|:---------------------------| | `type` | String | `ledgerClosed` indicates this is from the ledger stream | | `fee_base` | Number | The [reference transaction cost](transaction-cost.html#reference-transaction-cost) as of this ledger version, in [drops of XRP][]. If this ledger version includes a [SetFee pseudo-transaction](setfee.html) the new transaction cost applies starting with the following ledger version. | -| `fee_ref` | Number | The [reference transaction cost](transaction-cost.html#reference-transaction-cost) in "fee units". | +| `fee_ref` | Number | _(May be omitted)_ The [reference transaction cost](transaction-cost.html#reference-transaction-cost) in "fee units". Will be permanently omitted if the _[XRPFees amendment][]_ is enabled, because it will no longer have any meaning. | | `ledger_hash` | String - [Hash][] | The identifying hash of the ledger version that was closed. | | `ledger_index` | Number - [Ledger Index][] | The ledger index of the ledger that was closed. | | `ledger_time` | Number | The time this ledger was closed, in [seconds since the Ripple Epoch][] | From 34a3d23cbcfa5b6b7d06f129d8bd8f727afd5b69 Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Tue, 3 Oct 2023 17:22:06 -0400 Subject: [PATCH 2/3] Take @intelliot's suggestion to reword. Co-authored-by: Elliot Lee --- .../public-api-methods/subscription-methods/subscribe.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md b/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md index f14b5525505..ad675725ff0 100644 --- a/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md +++ b/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md @@ -169,7 +169,7 @@ The fields from a ledger stream message are as follows: |:--------------------|:--------------------------|:---------------------------| | `type` | String | `ledgerClosed` indicates this is from the ledger stream | | `fee_base` | Number | The [reference transaction cost](transaction-cost.html#reference-transaction-cost) as of this ledger version, in [drops of XRP][]. If this ledger version includes a [SetFee pseudo-transaction](setfee.html) the new transaction cost applies starting with the following ledger version. | -| `fee_ref` | Number | _(May be omitted)_ The [reference transaction cost](transaction-cost.html#reference-transaction-cost) in "fee units". Will be permanently omitted if the _[XRPFees amendment][]_ is enabled, because it will no longer have any meaning. | +| `fee_ref` | Number | _(May be omitted)_ The [reference transaction cost](transaction-cost.html#reference-transaction-cost) in "fee units". If the _[XRPFees amendment][]_ is enabled, it is permanently omitted, as it will no longer be relevant. | | `ledger_hash` | String - [Hash][] | The identifying hash of the ledger version that was closed. | | `ledger_index` | Number - [Ledger Index][] | The ledger index of the ledger that was closed. | | `ledger_time` | Number | The time this ledger was closed, in [seconds since the Ripple Epoch][] | From 2e1d5d32cc9c0d3f06573acf2a9faa288161a2ee Mon Sep 17 00:00:00 2001 From: Elliot Lee Date: Mon, 9 Oct 2023 23:20:34 -0700 Subject: [PATCH 3/3] Update content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md Co-authored-by: Amarantha Kulkarni --- .../public-api-methods/subscription-methods/subscribe.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md b/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md index ad675725ff0..b2e12a32bb7 100644 --- a/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md +++ b/content/references/http-websocket-apis/public-api-methods/subscription-methods/subscribe.md @@ -169,7 +169,7 @@ The fields from a ledger stream message are as follows: |:--------------------|:--------------------------|:---------------------------| | `type` | String | `ledgerClosed` indicates this is from the ledger stream | | `fee_base` | Number | The [reference transaction cost](transaction-cost.html#reference-transaction-cost) as of this ledger version, in [drops of XRP][]. If this ledger version includes a [SetFee pseudo-transaction](setfee.html) the new transaction cost applies starting with the following ledger version. | -| `fee_ref` | Number | _(May be omitted)_ The [reference transaction cost](transaction-cost.html#reference-transaction-cost) in "fee units". If the _[XRPFees amendment][]_ is enabled, it is permanently omitted, as it will no longer be relevant. | +| `fee_ref` | Number | _(May be omitted)_ The [reference transaction cost](transaction-cost.html#reference-transaction-cost) in "fee units". If the _[XRPFees amendment][]_ is enabled, this field is permanently omitted as it will no longer be relevant. | | `ledger_hash` | String - [Hash][] | The identifying hash of the ledger version that was closed. | | `ledger_index` | Number - [Ledger Index][] | The ledger index of the ledger that was closed. | | `ledger_time` | Number | The time this ledger was closed, in [seconds since the Ripple Epoch][] |