Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nftoken_id, nftoken_ids and offer_id meta fields into NFT Tx responses #574

Closed
ckniffen opened this issue May 19, 2023 · 1 comment
Closed

Add nftoken_id, nftoken_ids and offer_id meta fields into NFT Tx responses #574

ckniffen opened this issue May 19, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ckniffen
Copy link
Collaborator

NFToken transactions have these meta fields being added to a transactions response in [email protected]. Typing information needs to be added for them.

See: XRPLF/rippled#4447
@ckniffen ckniffen added enhancement New feature or request good first issue Good for newcomers labels May 19, 2023
@ckniffen ckniffen changed the title Add nftoken_id, nftoken_ids and offer_id meta fields into NFT Tx responses Add nftoken_id, nftoken_ids and offer_id meta fields into NFT Tx responses May 19, 2023
@pdp2121
Copy link
Collaborator

pdp2121 commented Jun 23, 2023

This would be parsed into result field of Response:
result: Dict[str, Any] = REQUIRED # type: ignore

No further action needed here.

@pdp2121 pdp2121 closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckniffen @pdp2121