Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Reset transaction cost must be 0 #764

Open
ckeshava opened this issue Oct 30, 2024 · 1 comment
Open

Key Reset transaction cost must be 0 #764

ckeshava opened this issue Oct 30, 2024 · 1 comment

Comments

@ckeshava
Copy link
Collaborator

The client libraries do not account for special transaction costs of the SetRegularKey transaction. Check this page: https://xrpl.org/docs/concepts/transactions/transaction-cost#special-transaction-costs

At the moment, I believe the reference-transaction-cost of 10 drops will be included with Key Reset transactions. I don't have a test case to prove the behavior.

This special transaction needs to be included in both xrpl-py and xrpl.js libraries.

@ckeshava
Copy link
Collaborator Author

This is the culprit function: https://github.com/ckeshava/xrpl-py/blob/f182eadc10aa1995cf82aaedff14216fd565ec2d/xrpl/asyncio/transaction/main.py#L424

There's a similarly named function in xrpl.js as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant