Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to current upstream PDCLib #33

Closed
wants to merge 97 commits into from
Closed

Conversation

dracc
Copy link

@dracc dracc commented Jul 27, 2020

Updates from 4f5b433 to 0b1e738. Main changes are:

Closes #28

solar and others added 30 commits December 18, 2019 12:39
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@850 bcf39385-58cc-4174-9fcf-14f50f90dd47
…ixed.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@851 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@852 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@853 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@854 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@855 bcf39385-58cc-4174-9fcf-14f50f90dd47
… by freopen()).

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@856 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@857 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@858 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@859 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@860 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@861 bcf39385-58cc-4174-9fcf-14f50f90dd47
…he ability to compile on my mobile.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@862 bcf39385-58cc-4174-9fcf-14f50f90dd47
…anks to sam-itt for pointing it out (GitHub issue XboxDev#10).

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@863 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@864 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@865 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@866 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@867 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@868 bcf39385-58cc-4174-9fcf-14f50f90dd47
…hackery anyway.)

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@869 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@872 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@873 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@874 bcf39385-58cc-4174-9fcf-14f50f90dd47
… with the space for the FILE struct.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@875 bcf39385-58cc-4174-9fcf-14f50f90dd47
…s. Comment fix.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@876 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@877 bcf39385-58cc-4174-9fcf-14f50f90dd47
solar and others added 25 commits May 24, 2020 20:42
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@914 bcf39385-58cc-4174-9fcf-14f50f90dd47
…he letter of the standard.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@915 bcf39385-58cc-4174-9fcf-14f50f90dd47
… has bugged me a long time.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@917 bcf39385-58cc-4174-9fcf-14f50f90dd47
git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@918 bcf39385-58cc-4174-9fcf-14f50f90dd47
…piler warnings.

git-svn-id: svn://rootdirectory.ddns.net/pdclib/trunk@919 bcf39385-58cc-4174-9fcf-14f50f90dd47
The offset between win32 and unix epochs wasn't taken care of,
resulting in a wrong value. Added the correct offset from ntfs3g.
@JayFoxRox
Copy link
Member

The commits without prefix should probably be touched while we are rebasing anyway.

The reason why we didn't do the update yet, is because we also have to bring in changes from the upstream pdclib to our xbox platform folder. Did you do this properly? This means reviewing each commit and documenting the changes so we can re-apply them (including style-changes etc.).

We should probably also wait for #31 and #32 because when we rebase those PRs would be broken.

@JayFoxRox
Copy link
Member

What's the status on this?

@dracc
Copy link
Author

dracc commented Apr 11, 2021

Updating the submodule was a bigger task than I anticipated and it turned out that I didn't have the skills nor time required to take care of it.
Closing, hopefully someone with a more suitable skillset picks up the torch.

@dracc dracc closed this Apr 11, 2021
@dracc dracc deleted the upstream_rebase branch April 11, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Base version (4f5b433) is outdated sscanf() is broken (hangs / stores unexpected values)
5 participants