Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppeteer imported but not in dependencies #152

Open
regseb opened this issue Jan 9, 2025 · 0 comments
Open

puppeteer imported but not in dependencies #152

regseb opened this issue Jan 9, 2025 · 0 comments

Comments

@regseb
Copy link

regseb commented Jan 9, 2025

Description

puppeteer is imported into the source code, but it's not into the published dependencies.

I use ghost-cursor, but I don't have puppeteer (I use playwright).

I think ghost-cursor should export two files:

  • One with basic features that doesn't use puppeteer: path()
  • Another with all features, including those requiring puppeteer: path(), createCursor()...

To reproduce

  • package.json

    {
      "name": "testcase",
      "version": "1.0.0",
      "type": "module",
      "dependencies": {
        "ghost-cursor": "1.3.0",
        "typescript": "5.7.3"
      }
    }
  • index.ts

    import { path } from "ghost-cursor";
  1. npm install
  2. npx tsc index.ts
    node_modules/ghost-cursor/lib/mouse-helper.d.ts:1:27 - error TS2307: Cannot find module 'puppeteer' or its corresponding type declarations.
    
    1 import type { Page } from 'puppeteer';
                                ~~~~~~~~~~~
    
    node_modules/ghost-cursor/lib/spoof.d.ts:1:50 - error TS2307: Cannot find module 'puppeteer' or its corresponding type declarations.
    
    1 import { ElementHandle, Page, BoundingBox } from 'puppeteer';
                                                       ~~~~~~~~~~~
    
    
    Found 2 errors in 2 files.
    
    Errors  Files
         1  node_modules/ghost-cursor/lib/mouse-helper.d.ts:1
         1  node_modules/ghost-cursor/lib/spoof.d.ts:1
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant