[Sod] Add Auras - Hunter - "Aspect of the Lion" is now "Heart of the Lion"

[augerT]

Description

Aspect of the Lion is now Heart of the Lion.

Tried updating the Spell ID name but I still get "UNKNOWN REQUIREMENT" from blazor server...

Addon Version

1.7.50

World of Warcraft Client

Season of Mastery

Reproduction Steps

1. Add Heart of the Lion as a requirement to an action
2. Start server
3. "UNKOWN REQUIREMENT! Heart of the Lion"

Last Good Version

No response

Screenshots

Logs

No response

[Xian55]

Hello there, i have not yet added any kind of Season of Mastery based spells to the requirements.

In the past few weeks i've played a little bit of hunter, to my knowledge around 13th of December, they changed how the formerly known Aspect of the Lion worked, previously it was an active Aura, then later on they changed to a Passive Aura. So you can have another spell active such as Aspect of the hawk.

I'm not completely sure how i should handle the Season of Mastery spells among requirements. Blizzard is probably going to keep adding more spells, or radically change a few. My goal is to keep the backward compatibility with the vanilla client as much as possible.
On the other hand, some of the classes like Paladins probably going to have more then 24 buff to track.

Currently what i can recommend, is to use the Player buff timer
Note that, you have to use the spell texture Id, what you can lookup in wowhead, this is a less reliable way to this, as the player buff timers, not extracted in a single frame, but spread around in time. So you may add a "Cooldown": 5000 or something like that to the KeyAction definition, to avoid infinitely toggling on and off the spell.

[augerT]

Thanks for the reply. I have another work around for heart of the lion but I'll keep this in mind for future sod spells.

[Xian55]

I've updated the dbc data with the latest 1.15.0.52610 patch since ae34220

Sadly none of the PTR servers are online, i'm going to test it, once any of the servers come back online.

[Xian55]

After thinking about the problem, i think it would be the best to use Trigger Requirement for Season of Discovery based player/target buffs and debuffs.

Essentially it gives the same performance as the hand written one, however the aura uptime is driven by an in-game addon such as WeakAura.

I'm just not sure how long does Season of Discovery lasts, and how often it will be updated.

The readme example should give all the info what needs to be done to achieve it.