Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trigger for disable XDCx precompiles #509

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

wanwiset25
Copy link
Collaborator

@wanwiset25 wanwiset25 commented Mar 27, 2024

Proposed changes

This change is a part of disabling XDCx, removing precompile contracts addresses after the switch block.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

core/vm/evm.go Outdated Show resolved Hide resolved
core/vm/evm.go Outdated Show resolved Hide resolved
@wanwiset25 wanwiset25 force-pushed the disable-precompiles branch 2 times, most recently from 7bbcf98 to bb0773f Compare April 1, 2024 12:31
params/config.go Outdated Show resolved Hide resolved
// expected: common.Bytes2Hex(common.LeftPadBytes(BTCUSDTLastPrice.Bytes(), XDCXPriceNumberOfBytesReturn)),
// name: "BTCUSDT",
// },
//since we diable XDCx precompiles, the test now returns 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add a space:

// since we diable XDCx precompiles, the test now returns 0

@wanwiset25 wanwiset25 force-pushed the disable-precompiles branch from 0c83fae to 2d3a9d7 Compare April 22, 2024 07:42
@wanwiset25 wanwiset25 merged commit fb91c1e into dev-upgrade Apr 22, 2024
18 checks passed
@wanwiset25 wanwiset25 deleted the disable-precompiles branch April 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants