forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add trigger for disable XDCx precompiles #509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzliudan
reviewed
Mar 28, 2024
gzliudan
reviewed
Mar 29, 2024
gzliudan
reviewed
Apr 1, 2024
gzliudan
reviewed
Apr 1, 2024
wanwiset25
force-pushed
the
disable-precompiles
branch
2 times, most recently
from
April 1, 2024 12:31
7bbcf98
to
bb0773f
Compare
gzliudan
reviewed
Apr 1, 2024
wanwiset25
force-pushed
the
disable-precompiles
branch
from
April 2, 2024 11:16
bb0773f
to
c784431
Compare
wanwiset25
force-pushed
the
disable-precompiles
branch
from
April 22, 2024 06:30
c784431
to
0c83fae
Compare
gzliudan
reviewed
Apr 22, 2024
core/vm/contracts_test.go
Outdated
// expected: common.Bytes2Hex(common.LeftPadBytes(BTCUSDTLastPrice.Bytes(), XDCXPriceNumberOfBytesReturn)), | ||
// name: "BTCUSDT", | ||
// }, | ||
//since we diable XDCx precompiles, the test now returns 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add a space:
// since we diable XDCx precompiles, the test now returns 0
liam-lai
approved these changes
Apr 22, 2024
wanwiset25
force-pushed
the
disable-precompiles
branch
from
April 22, 2024 07:42
0c83fae
to
2d3a9d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change is a part of disabling XDCx, removing precompile contracts addresses after the switch block.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that