Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename function doCall and doEstimateGas #516

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Apr 7, 2024

Proposed changes

This PR refactor functions about eth_call and eth_estimateGas:

  1. change func (s *PublicBlockChainAPI) doCall to func DoCall.
  2. change func (s *PublicBlockChainAPI) doEstimateGas to func DoEstimateGas.
  3. change b.BlockByNumber(ctx, rpc.LatestBlockNumber) to b.BlockByNumberOrHash(ctx, blockNrOrHash) in function DoEstimateGas to support all blocks.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan merged commit 1ca9930 into XinFinOrg:dev-upgrade Apr 7, 2024
17 checks passed
@gzliudan gzliudan deleted the estimate-gas branch April 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants