use 0x address scheme by default and add new enable xdc prefix flag #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzliudan
reviewed
Apr 9, 2024
gzliudan
approved these changes
Apr 9, 2024
liam-lai
reviewed
Apr 9, 2024
| @@ -933,6 +941,7 @@ func SetNodeConfig(ctx *cli.Context, cfg *node.Config) { | |||
| setHTTP(ctx, cfg) | |||
| setWS(ctx, cfg) | |||
| setNodeUserIdent(ctx, cfg) | |||
| setPrefix(ctx, cfg) | |||
liam-lai
approved these changes
Apr 9, 2024
wanwiset25
commented
Apr 9, 2024
| @@ -81,5 +81,5 @@ XDC --ethstats ${netstats} --gcmode archive \ | |||
| --rpcvhosts "*" --unlock "${wallet}" --password /work/.pwd --mine \ | |||
| --gasprice "1" --targetgaslimit "420000000" --verbosity ${log_level} \ | |||
| --debugdatadir /work/xdcchain \ | |||
| --enable-0x-prefix --ws --wsaddr=0.0.0.0 --wsport $ws_port \ | |||
| --ws --wsaddr=0.0.0.0 --wsport $ws_port \ | |||
liam-lai
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As agreed by the developer community to enable 0x prefix as default going forward. This will make sure we have less friction with new partners at later date.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that