forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade tx pool #528
Merged
Merged
upgrade tx pool #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzliudan
requested review from
wjrjerome,
liam-lai,
wgr523,
AnilChinchawale,
GalaxySciTech,
fishermanymc and
wanwiset25
April 30, 2024 10:30
wgr523
approved these changes
May 1, 2024
gzliudan
force-pushed
the
tx-pool
branch
2 times, most recently
from
May 8, 2024 06:10
dd5ee19
to
ec4b8e2
Compare
…ention in TxPool.Get. (ethereum#16670)
jrwbabylonlab
approved these changes
May 9, 2024
wjrjerome
approved these changes
May 9, 2024
liam-icheng-lai
approved these changes
May 10, 2024
liam-lai
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Pick below PR from ethereum for EIP-1559:
sync.RWMutex
forTxPool.all
to remove contention inTxPool.Get
. ethereum/go-ethereum#16670Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that