Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout on eval-system too agressive? #2221

Open
woutersj opened this issue Jan 13, 2025 · 1 comment
Open

Timeout on eval-system too agressive? #2221

woutersj opened this issue Jan 13, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@woutersj
Copy link
Contributor

Mogan Version

1.2.9.8

Operating System Version and Architecture

Fedora Linux 40 (GNOME Wayland)

Describe Bug

eval-system sometimes fails to capture output of a command.

I suspect this is due to a too short timeout in lolly::system::check_stdout .

I have tested this with (eval-system "python3 /home/jeroen/test.py"), where test.py contains

import time
time.sleep(0.2)
print("hello world")

Depending on the delay the output is captured or not.

Expected Behavior

Output is captured.

@woutersj woutersj added the bug Something isn't working label Jan 13, 2025
@woutersj
Copy link
Contributor Author

I verified the issue in lolly. It can be resolved by increasing the timeout in subprocess.hpp from 20 to, say, 2000. However, the longer the timeout, the longer subprocesses take to return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant