Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared mode keyboard conflicts #1373

Closed
totaam opened this issue Nov 29, 2016 · 6 comments
Closed

shared mode keyboard conflicts #1373

totaam opened this issue Nov 29, 2016 · 6 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 29, 2016

Issue migrated from trac ticket # 1373

component: server | priority: major | resolution: fixed

2016-11-29 07:03:36: antoine created the issue


Follow up from #41#comment:39.
Each new client connection overwrites the keymap.

We need to keep track of who owns the keyboard (separate from "ui-driver"?) and either:

  • change the keymap on the fly when a new user interacts with the session - hard, may not work well as setting the keymap is partly asynchronous
  • translate keyboard events for the "other" clients
@totaam
Copy link
Collaborator Author

totaam commented Feb 18, 2017

2017-02-18 10:01:25: antoine changed owner from antoine to afarr

@totaam
Copy link
Collaborator Author

totaam commented Feb 18, 2017

2017-02-18 10:01:25: antoine commented


Done in r15110.
We can now connect multiple clients with completely different keymaps (different OS, different layout, etc) and each client should still be able to use most of their keys..
The first client to connect will still "own" the keymap, which means that we won't be adding new layouts from the secondary clients.

How to test:

  • start a server with sharing enabled
  • connect a win32 client (for example) with a 'fr' layout (which has 'a' and 'q' keys swapped)
  • connect a linux client with a 'us' layout

Both clients should be able to use the keyboard and have the correct keys appear in applications (ie: xterm).

Note: this ticket is not meant to give 100% coverage of keyboard input when sharing is enabled (which may not be achievable anyway), just to make it a lot more usable than before.

@totaam
Copy link
Collaborator Author

totaam commented Jun 20, 2017

2017-06-20 20:58:14: maxmylyn changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Jun 20, 2017

2017-06-20 20:58:14: maxmylyn set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Jun 20, 2017

2017-06-20 20:58:14: maxmylyn commented


Tested (trunk Fedora 25 server, and Fedora 25 and Win8.1 clients) and it seems to behave, at least with my two identically-layed-out ENG-US keyboards. Closing

@totaam totaam closed this as completed Jun 20, 2017
@totaam
Copy link
Collaborator Author

totaam commented Dec 6, 2017

2017-12-06 10:47:42: antoine commented


Follow up: #1716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant