fix fullscreen handling

[totaam]

Issue migrated from trac ticket # 1567

component: client | priority: major | resolution: fixed

2017-07-07 11:46:57: antoine created the issue

---

Fullscreen sort of works, as long as the server-side screen size matches the client's.
When it doesn't, the window backing is painted with an offset:

• if the server-side screen size is bigger, it overflows the screen
• it it is smaller, it only covers part of the client's screen area

This is made worse by the fact that the opengl client paints from the bottom of the screen (inverted Y coordinates), so the pointer location reported doesn't match what is on-screen...

[totaam]

2017-07-07 12:08:37: antoine changed status from new to closed

[totaam]

2017-07-07 12:08:37: antoine set resolution to fixed

[totaam]

2017-07-07 12:08:37: antoine commented

---

r16209 added a Shift+F11 client-side fullscreen switch so we can make any window fullscreen, even an xterm - useful for testing.
r16218 also makes it easier to test: XPRA_FORCE_SCREEN_MISMATCH=1 will ensure that the server-side resolution used by desktop servers never matches the client's.
ie:

FORCE_SCREEN_MISMATCH=1 xpra start-desktop --start=xterm -d screen,geometry

xpra attach -d geometry

Then hit Shift+F11 and the xterm is shown in one place, but actually responds to mouse events at an offset..

---

Should be fixed in r16219.

Related tickets:

• FullScreen mode in xpra client #972
• allow client side shadow windows to be resized #530
• screen doesn't fit in Fullscreen mode #1327

[totaam]

2017-07-10 10:33:14: antoine commented

---

Note on resolutions: if we cannot find a match for the client's screen size in the server's list of pre-defined resolutions, then the fullscreened window will be displayed with black borders around it.

The steps in the list of resolutions are 64 pixels below 4k, and 128 pixels for resolutions above 4k.
So the worst case scenario (which should be rare) is that you will get about 30 black pixels around the window when showing fullscreen. (and double that for resolutions higher than 4k)
The most common resolutions are already pre-defined and will work without borders (ie: 1080p, 1440p, 1600x1200, etc..)

[totaam]

2017-08-11 14:59:35: antoine commented

---

The Shift+F11 shortcut was being ignored on MS Windows upgrades because the default system wide config was not being overwritten on upgrade - this is changed in r16426.
This means that modifying the default system config should be done by adding new files in xpra/conf.d and not by modifying existing ones as those will be overwritten on the next upgrade.

[totaam]

2017-09-01 06:46:11: antoine commented

---

Added to older branches in 16761 + 16762.