Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI library: Improve RTL support #21887

Open
vraja-pro opened this issue Dec 2, 2024 · 1 comment · May be fixed by #21909
Open

UI library: Improve RTL support #21887

vraja-pro opened this issue Dec 2, 2024 · 1 comment · May be fixed by #21909
Assignees

Comments

@vraja-pro
Copy link
Contributor

vraja-pro commented Dec 2, 2024

Context: Why was this issue created?

We don't support RTL in the storybook, the grunt build RTL is applicable only for the plugin css.
It turns the entire css to RTL.

What is the goal of this issue?

Add support for RTL in the storybooks

What needs to be done to achieve the goal?

We need to add RTL classes and not rely on the grunt tasks that build the rtl css for the plugin.

Does the issue still need UX or research?

No

If available: what are the tips for fixing the problem or possible solutions?

  • Instead of using yst-text-right or yst-text-left use something that in in the context of the direction: yst-text-start or yst-text-end.
  • We will need to look for all the margin and padding text for right and left and add the rtl equivalent.
  • See f we can move the arrow icon in the select field on rtl.
  • Exclude the ui library and related-keyphrase-suggestions packages from the grunt build of the rtl file.
  • Pay attention to translate-x classes, like with the tooltip.
  • Avoid margin by using yst-gap

What is the expected result/behavior?

  • Run the storybook and click on Direction on the top left corner.
  • Check all the components are in the rtl direction.

Should documentation be added or updated for this change? and if so, where?

No

@igorschoester igorschoester self-assigned this Dec 5, 2024
@igorschoester
Copy link
Member

Needs TailwindCSS v3.3.0+ for:

Add logical properties support for inline direction (tailwindlabs/tailwindcss#10166)

@igorschoester igorschoester linked a pull request Dec 10, 2024 that will close this issue
18 tasks
@igorschoester igorschoester changed the title RTL support for ui-library UI library: Improve RTL support Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants