Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the score API endpoints #21867

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from

Conversation

leonidasmi
Copy link
Contributor

@leonidasmi leonidasmi commented Nov 27, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds tests for the score API endpoints

Relevant technical choices:

  • In sitemap tests, I had to explicitly set the dates of the three posts to be in sequence of the order they were created, because otherwise getting those posts was getting tangled ever since we created posts for the Get_Scores_Test classes, for some reason

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/355

@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build de087bc7c7be2665affa71ae02ecfe2b6dbd7f25

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 54.649%

Totals Coverage Status
Change from base Build 36621d93f1d81d8da298f2cb331fbd4e4a8a881e: 0.3%
Covered Lines: 30125
Relevant Lines: 55473

💛 - Coveralls

@leonidasmi leonidasmi force-pushed the 538-add-integration-tests-for-the-api-endpoints branch 2 times, most recently from 4743d2c to 90aa20b Compare November 29, 2024 11:06
@leonidasmi leonidasmi force-pushed the 538-add-integration-tests-for-the-api-endpoints branch from 90aa20b to 47c9ac5 Compare November 29, 2024 11:14
Base automatically changed from feature/dash-phase-1 to trunk December 3, 2024 10:40
@leonidasmi leonidasmi force-pushed the 538-add-integration-tests-for-the-api-endpoints branch 6 times, most recently from cab7f95 to c9a8a11 Compare December 6, 2024 14:17
@leonidasmi leonidasmi force-pushed the 538-add-integration-tests-for-the-api-endpoints branch 15 times, most recently from 332eaf2 to b4fdfdb Compare December 9, 2024 11:10
@leonidasmi leonidasmi force-pushed the 538-add-integration-tests-for-the-api-endpoints branch from b4fdfdb to 8f5b1fd Compare December 9, 2024 14:16
@leonidasmi leonidasmi force-pushed the 538-add-integration-tests-for-the-api-endpoints branch from 8283903 to 2a64b35 Compare December 9, 2024 14:24
@leonidasmi leonidasmi marked this pull request as ready for review December 9, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants