Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text color of table cells #21916

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

d-claassen
Copy link
Contributor

Context

Slate 500 is used for placeholder text, the default text color should be slate 600. This applies to table cells as well. These tables are used at:

  • in the Semrush related keyword suggestions table
  • in the RSS settings table explaining the available variables

Summary

This PR can be summarized in the following changelog entry:

  • Improve contrast in the related keyphrase suggestions table.
  • Improve contrast in the RSS supported variables explainer table.
  • [@yoast/ui-library 0.0.1] Improve contrast of default text color in Table.Cell.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Check the text color in the cells in the Semrush related keyphrases.
  • Check the text color in the cells in the RSS table explaining the available variables in the Settings page.
  • Check the text color of cells in the Storybook for the UI library.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • changes one class name on the Table.Cell component of the UI library, wherever that component is used this might be relevant. I believe i've named all.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Slate 500 is used for placeholder text, default color should be slate 600. This applies to table cells as well.

Tables are used in the plugin:

- in the Semrush related keyword suggestions table
- in the RSS settings table explaining the available variables
@d-claassen d-claassen requested a review from a team as a code owner December 13, 2024 12:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build e5be6a1dab58683b629b490f03bbabaef63769e0

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.386%

Totals Coverage Status
Change from base Build b602854da9bd10c690131950c0472809c3328df6: 0.0%
Covered Lines: 29938
Relevant Lines: 55464

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants