Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related kephrase suggestion table: break translation for "Add keyphrase" and align to end #21917

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Dec 13, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adjusts the design for the related keyphrase suggestions table header.
  • [@yoast/related-keyphrase-suggestions 0.1.0] Breaks the translation for the "Add keyphrase" header cell and align it to the end.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Edit a post with focus keyphrase when you are logged in to your Semrush account.
  • Check the table header for "Add keyphrase" is broken to two lines and aligned to the end of the cell.
  • Make sure that doesn't change when the table is loading.
  • Enable Yoast premium and add an remove keyphrases in the table, check that doesn't affect the table or cell width.
  • Check the same for RTL language.

Screenshot 2024-12-13 at 16 42 42
Screenshot 2024-12-13 at 16 45 18

Storybook

  • Check the same in the storybook under the components -> KeyphrasesTable.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 13, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1186b25bd8b32e6d099d9b9ea9239c0b0cc106fe

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.386%

Totals Coverage Status
Change from base Build b602854da9bd10c690131950c0472809c3328df6: 0.0%
Covered Lines: 29938
Relevant Lines: 55464

💛 - Coveralls

@vraja-pro vraja-pro changed the title break translation and align to end Related kephrase suggestion table: break translation for "Add keyphrase" and align to end Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants