Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

femto upgrade #69

Open
brettrowberry opened this issue Jun 24, 2020 · 11 comments
Open

femto upgrade #69

brettrowberry opened this issue Jun 24, 2020 · 11 comments

Comments

@brettrowberry
Copy link

Would it make sense for there to be a femto upgrade that basically calls dotnet paket upgrade && yarn upgrade?

@MangelMaxime
Copy link
Collaborator

MangelMaxime commented Jun 25, 2020

Hello, just giving my opinion.

For me, Femto is for working with the npm dependencies I don't think I want it to touch my .NET dependencies.

Currently, you can update your .NET dependencies using paket or dotnet. Then you can run femto resolve which will resolve and install the correct version of npm dependencies based on the installed .NET dependencies.

Also femto would need to detect if you are using paket or dotnet to manage your .NET dependencies and call the corresponding one like it does for npm/yarn.

@Zaid-Ajaj
Copy link
Owner

@MangelMaxime Actually Femto does interact with your dotnet dependencies when you run femto install or femto uninstall.

@brettrowberry An upgrade command would be a nice to have though not really needed since you can simply run paket upgrade yourself and then run femto --resolve afterwards. NOT yarn upgrade because we don't know which packages will be required by the new versions of the dotnet dependencies, so just femto --resolve and let it do the magic.

A PR would be really appreciated 🙏 a lot of the work is already done here (finding paket and invoking it) so only adding the command line arg, executing paket upgrade and then femto --resolve

@MangelMaxime

This comment has been minimized.

@brettrowberry
Copy link
Author

That makes sense. So a femto upgrade would really be a paket upgrade and femto --resolve.

@brettrowberry
Copy link
Author

And it would only be possible if paket is used, not nuget.

@Zaid-Ajaj
Copy link
Owner

Zaid-Ajaj commented Jun 25, 2020

@brettrowberry Yes only for paket. Unless of course you are feeling extremely adventurous and want to implement the functionality for Femto to do nuget update 😄 No just kidding, this would be like opening a pandora's box

@MangelMaxime
Copy link
Collaborator

It would be strange if femto install and femto uninstall works with paket and dotnet but not femto update no?

In theory, we just need to execute dotnet update against the specified fsproj or is there something else I don't see?

@Zaid-Ajaj
Copy link
Owner

Zaid-Ajaj commented Jun 25, 2020

@MangelMaxime I don't think dotnet has an update command like paket does. Dotnet only has add package and it is only per-project.

@MangelMaxime
Copy link
Collaborator

Oops didn't know that. 😅

Then we should just warn that it is not supported in the console because the user doesn't use paket. Just so he knows why :) <- Thinking about future me 😂

@Zaid-Ajaj
Copy link
Owner

lol 😂 yeah absolutely: if we can't find paket then we simply say this is a paket-only feature

@brettrowberry
Copy link
Author

Anybody want to pair on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants