Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch zebrad to a non-blocking tracing logger #4834

Closed
Tracked by #3096
teor2345 opened this issue Jul 27, 2022 · 0 comments · Fixed by #5032
Closed
Tracked by #3096

Switch zebrad to a non-blocking tracing logger #4834

teor2345 opened this issue Jul 27, 2022 · 0 comments · Fixed by #5032
Assignees
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug I-hang A Zebra component stops responding to requests I-usability Zebra is hard to understand or use

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 27, 2022

Motivation

Some of our tests might be deadlocking when the log buffers fill up.
This could happen to users as well.

This is a high priority, because it is causing test failures.

API Reference

https://docs.rs/tracing-appender/0.2.2/tracing_appender/#non-blocking-writer

Designs

  • Use tracing-appender to make stdout writes non-blocking
  • Use a lossy logger, so we drop any output we can't write, rather than blocking
@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-High 🔥 I-hang A Zebra component stops responding to requests I-integration-fail Continuous integration fails, including build and test failures A-diagnostics Area: Diagnosing issues or monitoring performance labels Jul 27, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Aug 1, 2022
@teor2345 teor2345 added the I-usability Zebra is hard to understand or use label Aug 23, 2022
@teor2345 teor2345 added P-Medium ⚡ and removed P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures labels Aug 23, 2022
@mergify mergify bot closed this as completed in #5032 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug I-hang A Zebra component stops responding to requests I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants