Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StateService requests into concurrent ReadStateService requests #5102

Closed
Tracked by #4937
teor2345 opened this issue Sep 6, 2022 · 2 comments · Fixed by #5107
Closed
Tracked by #4937

Make StateService requests into concurrent ReadStateService requests #5102

teor2345 opened this issue Sep 6, 2022 · 2 comments · Fixed by #5107
Assignees
@teor2345
Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug I-slow Problems with performance or responsiveness

Comments

@teor2345
Copy link
Contributor

teor2345 commented Sep 6, 2022 •
edited
Loading

Motivation

At the moment, Zebra reads the state via two different services:

  • a blocking StateService
  • a concurrent ReadStateService

Most read requests are able to be run concurrently, so we could move them to the ReadStateService. This allows us to move mutable chain state into the block commit task.

This should also improve performance.
@teor2345 teor2345 mentioned this issue Sep 6, 2022
Closed
12 tasks
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code I-slow Problems with performance or responsiveness P-Optional ✨ A-state Area: State / database changes labels Sep 6, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Sep 6, 2022

I'm just making this ticket in case we need it later.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Sep 8, 2022

It turns out this is the easiest way to do #4937.

@teor2345 teor2345 reopened this Sep 8, 2022
@teor2345 teor2345 self-assigned this Sep 8, 2022
This was referenced Sep 8, 2022
Merged
Merged
@mergify mergify bot closed this as completed in #5107 Sep 16, 2022
@teor2345 teor2345 mentioned this issue Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
1 participant
@teor2345