Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that mining pool software can connect to Zebra in CI, but don't mine any blocks #5304

Closed
mpguerra opened this issue Sep 29, 2022 · 2 comments
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-devops Area: Pipelines, CI/CD and Dockerfiles A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Sep 29, 2022

Motivation

We want to test our RPCs against the software that uses them, to make sure we got the names, parameters, and fields correct.

Proposed Solution

We can run the latest version of https://github.com/s-nomp/s-nomp , connect it to zebrad, and check for successes or failures in the logs.

This will be like the lightwalletd_integration test:

fn lightwalletd_integration_test(test_type: LightwalletdTestType) -> Result<()> {

Out of Scope

We won't be mining blocks in CI, we just want to make sure the miner can connect.

@mpguerra
Copy link
Contributor Author

mpguerra commented Sep 30, 2022

I don't think this needs to block development of the RPC calls. We can start development when we are ready to start work on this, and test against the mining pool software once we have it, first manually and then in CI once this issue is complete.

@teor2345 teor2345 changed the title Run mining pool software in CI to test zebrad RPCs Add a manually-triggered workflow for mining a block on testnet Jan 24, 2023
@teor2345 teor2345 changed the title Add a manually-triggered workflow for mining a block on testnet Check that mining pool software can connect to Zebra in CI, but don't mine any blocks Jan 24, 2023
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Optional ✨ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Jan 24, 2023
@teor2345
Copy link
Contributor

We decided that this was out of scope at the engineering meeting today. We only need to do this if the manual tests in #6025 aren't enough.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-devops Area: Pipelines, CI/CD and Dockerfiles A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests
Projects
None yet
Development

No branches or pull requests

2 participants