Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select getblocktemplate transactions according to ZIP-317 #5473

Closed
Tracked by #5235
, #5234
...
teor2345 opened this issue Oct 25, 2022 · 1 comment · Fixed by #5724
Closed
Tracked by #5235
, #5234
...

Select getblocktemplate transactions according to ZIP-317 #5473

teor2345 opened this issue Oct 25, 2022 · 1 comment · Fixed by #5724
Assignees
@teor2345
Labels
A-consensus Area: Consensus rule updates A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement I-heavy Problems with excessive memory, disk, or CPU usage I-remote-node-overload Zebra can overload other nodes on the network I-slow Problems with performance or responsiveness

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 25, 2022 •
edited
Loading

Motivation

We want to select transactions based on ZIP-317.

Specifications

The block production parts of:

The outdated ZIP-313 might also have some relevant information:
https://zips.z.cash/zip-0313

Design

When selecting transactions, we should do something similar to zcashd, based on ZIPs 317 and 313.

The ZIP editors have recommended including low-fee transactions in blocks with probability fee / conventional_fee. Zebra could implement this in the mempool, but that changes relaying as well, which we don't want to do yet. So using the RPC is best for now. The details are in https://hackmd.io/rgb38M_wSxa9kotyaON1fA

We should also check the sigop_limit before adding each new transaction to the block.

Related Tickets

Other parts of transaction selection will be handled by the mempool changes in #5335.
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium ⚡ I-heavy Problems with excessive memory, disk, or CPU usage I-slow Problems with performance or responsiveness I-remote-node-overload Zebra can overload other nodes on the network A-rpc Area: Remote Procedure Call interfaces labels Oct 25, 2022
This was referenced Oct 25, 2022
Closed
Closed
@mpguerra mpguerra mentioned this issue Oct 26, 2022
Closed
34 tasks
@mpguerra
Copy link
Contributor

mpguerra commented Nov 8, 2022

Hey team! Please add your planning poker estimate with Zenhub @arya2 @dconnolly @oxarbitrage @teor2345

@teor2345 teor2345 added the A-consensus Area: Consensus rule updates label Nov 8, 2022
This was referenced Nov 23, 2022
Merged
Merged
@mergify mergify bot closed this as completed in #5724 Dec 1, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-consensus Area: Consensus rule updates A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement I-heavy Problems with excessive memory, disk, or CPU usage I-remote-node-overload Zebra can overload other nodes on the network I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(rpc): Select getblocktemplate RPC transactions according to ZIP-317 ZcashFoundation/zebra
2 participants
@mpguerra @teor2345