Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare subtrees in non-finalized chains when evaluating chain equality #7447

Closed
Tracked by #6642
upbqdn opened this issue Sep 1, 2023 · 0 comments · Fixed by #7562
Closed
Tracked by #6642

Compare subtrees in non-finalized chains when evaluating chain equality #7447

upbqdn opened this issue Sep 1, 2023 · 0 comments · Fixed by #7562
Assignees
@upbqdn
Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug

Comments

@upbqdn
Copy link
Member

upbqdn commented Sep 1, 2023

Motivation

We added roots of note commitment subtrees into the non-finalized chain in PR #7334, but we forgot to take them into account when evaluating equality of chains in eq_internal_state.

Solution

Compare the subtree roots in eq_internal_state.

Adding the comparison will likely cause some tests to fail. We'll need to adjust those as well.
@upbqdn upbqdn added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-High 🔥 A-state Area: State / database changes labels Sep 1, 2023
@mpguerra mpguerra added this to Zebra Sep 1, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Sep 1, 2023
@upbqdn upbqdn changed the title Compare subtrees in non-finalized chains when evaluating chain equality Compare subtree roots in non-finalized chains when evaluating chain equality Sep 1, 2023
@upbqdn upbqdn mentioned this issue Sep 1, 2023
Closed
38 tasks
@upbqdn upbqdn changed the title Compare subtree roots in non-finalized chains when evaluating chain equality Compare subtrees in non-finalized chains when evaluating chain equality Sep 14, 2023
@upbqdn upbqdn mentioned this issue Sep 14, 2023
Merged
6 tasks
@mergify mergify bot closed this as completed in #7562 Sep 18, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upbqdn upbqdn

Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug
Projects
Zebra
Status: Done
Milestone
No milestone
2 participants
@mpguerra @upbqdn