-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zebra-state): Send a reference to latest non-finalized state in TipAction::Reset #7927
Comments
I think we're missing the ticket that this ticket enables: |
I was thinking this ticket could involve adding a method to be used instead of |
@mpguerra did we decide to move this issue to a later sprint? |
I updated this ticket based on the current scanning speed. We don't need a complicated solution because it is fast enough: |
@upbqdn @oxarbitrage I was wondering about adding a state request for getting the latest non-finalized state instead of adding it here, which makes more sense? |
We won't be doing any more work on the scanner |
Motivation
This is needed for the scanner task in zebra-scan (#7905) to get any blocks in the non-finalized portion of the best chain when there is a
Reset
action without repeated calls to the state service.Possible Design
latest_non_finalized_state
watch channel receiverLatestTipChange
that returns all the blocks in the latest non-finalized chainThis is acceptable because the worst-case scanning performance is 3 blocks per second, which means we can re-scan an entire non-finalized chain before the next block arrives. (Forks usually only happen every 300+ blocks.)
Alternative Solution
This solution is more complex than we need.
Too complicated
Add a method on
LatestTipChange
:Related Work
This ticket is required for:
The text was updated successfully, but these errors were encountered: