Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store decrypted scanning results in the scanner storage #7944

Closed
Tracked by #7728
teor2345 opened this issue Nov 14, 2023 · 1 comment
Closed
Tracked by #7728

Store decrypted scanning results in the scanner storage #7944

teor2345 opened this issue Nov 14, 2023 · 1 comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-enhancement Category: This is an improvement

Comments

@teor2345
Copy link
Contributor

Motivation

We want to store the decrypted results of scanning in the scanner storage.

Complex Code

These types look pretty complicated, so it might help to use HashMap's entry API.

It would be helpful to add type aliases for SaplingSpend and SaplingOutput, so we can change them later.

Suggested Design

In sapling_spend_results, when Nf is () it should become None.

    /// The new outputs created in each transaction, for each scanning key. 
    sapling_spend_results: HashMap<String, HashMap<Hash, WalletSaplingSpend>>,

    /// The spent outputs by each transaction, for each scanning key.
    /// If the scanning key is an individual viewing key (without a nullifier deriving key), there are no nullifiers in those results.
    sapling_spend_results: HashMap<String, HashMap<Hash, WalletSaplingOutput<Option<Nullifier>>>>,

Originally posted by @teor2345 in #7942 (comment)

@mpguerra mpguerra added this to Zebra Nov 14, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Nov 14, 2023
@teor2345 teor2345 added C-enhancement Category: This is an improvement P-Medium ⚡ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Nov 14, 2023
@mpguerra
Copy link
Contributor

We won't be doing any more work on the scanner

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-enhancement Category: This is an improvement
Projects
Status: Done
Development

No branches or pull requests

2 participants