Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DeleteKeys scan service request to delete registered keys and any cached results for those keys #8204

Closed
arya2 opened this issue Jan 29, 2024 · 0 comments · Fixed by #8217
Closed

Implement DeleteKeys scan service request to delete registered keys and any cached results for those keys #8204

arya2 opened this issue Jan 29, 2024 · 0 comments · Fixed by #8217
Assignees
@arya2
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features S-needs-triage Status: A bug report needs triage
Milestone
RPC Interface for...

Comments

@arya2
Copy link
Contributor

arya2 commented Jan 29, 2024 •
edited
Loading

Motivation

We want to clear cached results and stop scanning for a key with a request to the scan service

Possible Design

  • Send a ScanTaskCommand::RemoveKeys {} message to the scanner task
    • Remove the key from the parsed_keys collection in the scan task and send a message notifying the caller that it's been removed
  • Wait for the scan task to confirm that the key has been removed
  • Implement and call a method on Storage to delete results for a key
@arya2 arya2 mentioned this issue Jan 29, 2024
Closed
@github-project-automation github-project-automation bot moved this to New in Zebra Jan 29, 2024
@arya2 arya2 added S-needs-triage Status: A bug report needs triage C-feature Category: New features A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Jan 29, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Jan 29, 2024
@arya2 arya2 mentioned this issue Jan 31, 2024
Merged
9 tasks
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in Zebra Jan 31, 2024
@mergify mergify bot closed this as completed in #8217 Jan 31, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arya2 arya2

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features S-needs-triage Status: A bug report needs triage
Projects
Zebra
Status: Done
Milestone
RPC Interface for Zebra Blockchain Sc...
Development

Successfully merging a pull request may close this issue.

add(scan): Implement DeleteKeys ScanService request ZcashFoundation/zebra
2 participants
@mpguerra @arya2