Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle RegisterKeys messages in the scanner task #8220

Closed
arya2 opened this issue Jan 31, 2024 · 0 comments · Fixed by #8222
Closed

Handle RegisterKeys messages in the scanner task #8220

arya2 opened this issue Jan 31, 2024 · 0 comments · Fixed by #8222
Assignees
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-concurrency Area: Async code, needs extra work to make it work properly. C-feature Category: New features P-Medium ⚡

Comments

@arya2
Copy link
Contributor

arya2 commented Jan 31, 2024

Motivation

We want to start scanning blocks for newly registered keys.

Possible Design

We could add an optional stop height to the scan::start() function, add the new keys to the parsed_keys collection when they are received, and spawn a task for scanning from the start height or sapling activation height until the latest block height scanned in the ScanTask for parsed keys.

@github-project-automation github-project-automation bot moved this to New in Zebra Jan 31, 2024
@arya2 arya2 self-assigned this Jan 31, 2024
@arya2 arya2 added A-concurrency Area: Async code, needs extra work to make it work properly. A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ C-feature Category: New features labels Jan 31, 2024
@mpguerra mpguerra moved this from New to In progress in Zebra Feb 5, 2024
@mergify mergify bot closed this as completed in #8222 Feb 6, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Zebra Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-concurrency Area: Async code, needs extra work to make it work properly. C-feature Category: New features P-Medium ⚡
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants