Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for gRPC methods #8244

Closed
arya2 opened this issue Feb 7, 2024 · 1 comment · Fixed by #8277, #8293 or #8296
Closed

Add tests for gRPC methods #8244

arya2 opened this issue Feb 7, 2024 · 1 comment · Fixed by #8277, #8293 or #8296
Assignees
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡

Comments

@arya2
Copy link
Contributor

arya2 commented Feb 7, 2024

Motivation

We want to have tests in CI to check that gRPC methods are working as expected.

Note: There's already test coverage for most of the logic in methods that have been implemented, and the gRPC methods have been manually tested, this issue is for filling the remaining gaps.

Possible Design

@arya2 arya2 added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Feb 7, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Feb 7, 2024
@arya2 arya2 changed the title Add tests for gRPC methods Add snapshot tests for gRPC methods Feb 7, 2024
@arya2 arya2 changed the title Add snapshot tests for gRPC methods Add tests for gRPC methods Feb 7, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Feb 13, 2024
@oxarbitrage oxarbitrage self-assigned this Feb 14, 2024
@mpguerra mpguerra linked a pull request Feb 16, 2024 that will close this issue
7 tasks
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in Zebra Feb 16, 2024
@mergify mergify bot closed this as completed in #8277 Feb 16, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Feb 16, 2024
@oxarbitrage oxarbitrage reopened this Feb 16, 2024
@oxarbitrage
Copy link
Contributor

Snapshots tests for the methods we had written were done at #8277
Other snapshots tests will be added in the PR of the method itself (For example #8268)

Unit tests foer the grpc methods will be done in a separated PR that will close this ticket.

@mpguerra mpguerra moved this from Done to In progress in Zebra Feb 19, 2024
@mergify mergify bot closed this as completed in #8293 Feb 20, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Zebra Feb 20, 2024
@mpguerra mpguerra linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡
Projects
Status: Done
3 participants