Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a disable_peers field to testnet::Parameters #8361

Open
Tracked by #7119 ...
arya2 opened this issue Mar 19, 2024 · 3 comments
Open
Tracked by #7119 ...

Add a disable_peers field to testnet::Parameters #8361

arya2 opened this issue Mar 19, 2024 · 3 comments
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-feature Category: New features C-testing Category: These are tests

Comments

@arya2
Copy link
Contributor

arya2 commented Mar 19, 2024

Motivation

We want to disable non-local peer connections for Regtest.

Note

Make sure to search for the issue number and address any TODOs.

@github-project-automation github-project-automation bot moved this to New in Zebra Mar 19, 2024
@arya2 arya2 added A-consensus Area: Consensus rule updates I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests C-feature Category: New features C-enhancement Category: This is an improvement and removed I-usability Zebra is hard to understand or use labels Mar 19, 2024
@arya2 arya2 changed the title Add an initial_peers field to Network Add an disable_peers field to Network Mar 19, 2024
@mpguerra mpguerra added this to the Regtest Network support milestone Mar 21, 2024
@arya2 arya2 moved this from New to Sprint Backlog in Zebra Apr 18, 2024
@mpguerra mpguerra moved this from Sprint Backlog to In progress in Zebra Apr 22, 2024
@arya2 arya2 changed the title Add an disable_peers field to Network Set peerset_initial_target_size to 0 on Regtest (Zebra should not make any peer connections) Apr 30, 2024
@arya2 arya2 changed the title Set peerset_initial_target_size to 0 on Regtest (Zebra should not make any peer connections) Add a disable_peers field to testnet::Parameters May 1, 2024
@arya2 arya2 self-assigned this May 1, 2024
@arya2 arya2 removed their assignment May 14, 2024
@mpguerra
Copy link
Contributor

@arya2 is this still necessary?

@mpguerra mpguerra moved this from In progress to Product Backlog in Zebra May 28, 2024
@arya2
Copy link
Contributor Author

arya2 commented Jun 20, 2024

@arya2 is this still necessary?

No, returning an empty set from the zebra_network::Config::initial_peers() method on Regtest is fine, at least for now.

It could be useful for creating isolated custom Testnets later, which would be like custom Regtest networks (Zebra's Regtest currently tries to closely match the zcashd Regtest parameters, users may want to closely match the Mainnet parameters instead).

@arya2 arya2 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@github-project-automation github-project-automation bot moved this from Product Backlog to Done in Zebra Jun 20, 2024
@mpguerra mpguerra removed the NU-6 Network Upgrade: NU6 specific tasks label Jul 25, 2024
@arya2 arya2 reopened this Jan 29, 2025
@arya2
Copy link
Contributor Author

arya2 commented Jan 29, 2025

This issue is still low-priority cleanup so that it's easy to configure Zebra to disallow peers on a custom Testnet, but it turned out zcashd's Regtest allows local connections and it's likely easier to fix this issue in parallel.

@mpguerra mpguerra moved this from Done to Sprint Backlog in Zebra Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-feature Category: New features C-testing Category: These are tests
Projects
Status: Sprint Backlog
Development

No branches or pull requests

2 participants