Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point and scalar validation #88

Open
omershlo opened this issue Oct 8, 2020 · 0 comments
Open

point and scalar validation #88

omershlo opened this issue Oct 8, 2020 · 0 comments
Labels
good first issue Good for newcomers high priority

Comments

@omershlo
Copy link
Contributor

omershlo commented Oct 8, 2020

Thanks to @ra-- who raised this issue:

I noticed that there were some unsafe unwrap calls/missing checks. E.g. https://github.com/ZenGo-X/curv/blob/master/src/elliptic/curves/secp256_k1.rs#L148 the scalar may be 0. Or here https://github.com/ZenGo-X/curv/blob/master/src/elliptic/curves/secp256_k1.rs#L160. Basically add, sub, mul, and invert should check whether the result is 0. For points, there are unsafe unwraps as well. Here for example: https://github.com/ZenGo-X/curv/blob/master/src/elliptic/curves/secp256_k1.rs#L414.

Error handling should be added as part of the point and scalar traits by way of returning Result. Here is an example:
nash-io/nash-rust@0910eb7#diff-bf4822a262bb2d66887c738137845d7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@omershlo