Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webmentions_count a "real" number #57

Closed
nhoizey opened this issue Aug 9, 2017 · 2 comments
Closed

Make webmentions_count a "real" number #57

nhoizey opened this issue Aug 9, 2017 · 2 comments

Comments

@nhoizey
Copy link
Contributor

nhoizey commented Aug 9, 2017

I've lost some time wondering why this liquid test didn't give me the result I was waiting for:

{{ webmentions_count }} webmention{% if webmentions_count > 1 %}s{% endif %}

It looks like webmentions_count is an HTML fragment, instead of just the number I was expecting.

The README says "The output will be a number".

IMHO, the HTML should be in the templates, and webmentions_count should indeed be a number.

@aarongustafson
Copy link
Owner

You can replace the default count template to make it a raw number if you like. Since it can be filtered I added the additional markup details.

@nhoizey
Copy link
Contributor Author

nhoizey commented Aug 11, 2017

You're right! I didn't see it was also a template.

@nhoizey nhoizey closed this as completed Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants