-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't break when a mentioned website doesn't respond #61
Comments
I will take a look @ this. |
Great, thanks! |
So, it's possible we might want to file this as a bug against the Webmention gem. I can make the calls isolated on my end but since I'm effectively outsourcing the Webmention action to that library, the fix should probably go there. It may even be a root issue in HTTParty or the Webmention gem’s implementation of it. |
Ok, I didn't see you're using another gem for these actions. |
So sending webmentions looks like it gets rescued, but checking for webmention support does not have a blanket rescue. I'm curious to see if fixing that resolves the issue. |
I just did a |
I don't understand at all what this |
It looks like it work, it doesn't stop anymore!
|
Sweet. I can comment out the logging when I get back to my computer. Probably late tonight or tomorrow. Catching a flight shortly. |
It didn't get to the end, I think:
Maybe it would be nice to have logs for success also, because I don't know if any worked. |
Oh, in fact the last one, just before the error, succeeded, it seems! It is there indeed: https://adactio.com/journal/7698#comment50941 At least @adactio accepts Webmentions… ;-) |
:-) Can you trace that command once more? I'm curious about that final error. |
I'm now on holyday, but I'll try. Is there a risk I send a Webmention to Jeremy again? |
It shouldn't. The Webmention is logged to a YAML file as sent.
|
Tested as working on my end. Fixed in 2.6.4. |
@aarongustafson I still get the error with current master. Here is just the end of the log:
|
Fixed in 2.8.2 |
Great, thanks! |
I have old posts on my blog, with links to sites that don't exist anymore.
When I run the
bundle exec jekyll webmention
command, it breaks when trying to send a mention to the first of these sites:Can I change
false
to anything else in thewebmention_io_outgoing.yml
file, to make the command ignore this mention?The text was updated successfully, but these errors were encountered: