Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDataReader type converter #989

Closed
riezebosch opened this issue Oct 3, 2024 · 2 comments
Closed

IDataReader type converter #989

riezebosch opened this issue Oct 3, 2024 · 2 comments

Comments

@riezebosch
Copy link

I created this extension on YamlDotNet: https://github.com/riezebosch/YamlDotNetDataReader/. Maybe it is something you want to include in the main library or publish it as an official companion library? The only (new) dependency is on Microsoft.Data.SqlClient which you may already have since I saw some checks on DBNull already?

@EdwardCooke
Copy link
Collaborator

We currently have no dependencies in yamldotnet and it’s something we’d really like to stay that way. It makes it easier for consumers of the package.

@riezebosch
Copy link
Author

riezebosch commented Oct 3, 2024

return value?.GetType()?.FullName == "System.DBNull";

okay, it's a weak dependency 😏

I do understand your stance though 👍🏻 But the second question is that it would/could make sense to make it an official companion package using the YamlDotNet reserved prefix 🤷🏻 Or we leave it as and I keep it as my package: https://nuget.org/packages/YamldotNetDataReader/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants