From cdea2ac86d8a9b9e92f76ff8cbeb6adcc157115f Mon Sep 17 00:00:00 2001 From: Mandar Kulkarni Date: Thu, 14 Apr 2022 07:26:51 -0700 Subject: [PATCH] ec2_asg: Change purge_tags default value to False (#1064) ec2_asg: Change purge_tags default value to False SUMMARY Changed default value of purge_tags to False. With the addition of purge_tags to ec2_asg module #960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide. With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required. This PR's change will prevent accidental breakage. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_asg Reviewed-by: Mark Chappell Reviewed-by: Markus Bergholz Reviewed-by: Mark Woolley Reviewed-by: Alina Buzachis --- ec2_asg.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ec2_asg.py b/ec2_asg.py index f95fb329ce5..0aa16aeaa0b 100644 --- a/ec2_asg.py +++ b/ec2_asg.py @@ -224,7 +224,7 @@ description: - If C(true), existing tags will be purged from the resource to match exactly what is defined by I(tags) parameter. - If the I(tags) parameter is not set then tags will not be modified. - default: true + default: false type: bool version_added: 3.2.0 health_check_period: @@ -1861,7 +1861,7 @@ def main(): wait_timeout=dict(type='int', default=300), state=dict(default='present', choices=['present', 'absent']), tags=dict(type='list', default=[], elements='dict'), - purge_tags=dict(type='bool', default=True), + purge_tags=dict(type='bool', default=False), health_check_period=dict(type='int', default=300), health_check_type=dict(default='EC2', choices=['EC2', 'ELB']), default_cooldown=dict(type='int', default=300),