Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Organize unit tests dependencies #24

Closed
cesarsouza opened this issue Jun 12, 2014 · 5 comments
Closed

Organize unit tests dependencies #24

cesarsouza opened this issue Jun 12, 2014 · 5 comments

Comments

@cesarsouza
Copy link
Member

In the main project, certain projects don't reference each other for obvious reasons. For example, Accord.Math cannot reference Accord.MachineLearning, but actually it is Accord.MachineLearning that should reference Accord.Math.

However, the same cannot be said for the unit tests. In the current version, the unit tests have references among themselves, which might be a bit confusing, specially if you are trying to disentangle them from the main project.

As such, uncommon dependencies must be removed, and the resulting broken tests and references should be fixed.

@cesarsouza
Copy link
Member Author

This shouldn't be an issue anymore.

@cesarsouza cesarsouza reopened this Apr 13, 2015
@cesarsouza
Copy link
Member Author

Reopening this issue to track the following changes:

  • Each unit test project should depend only on the assembly being tested and its dependencies
  • Unit tests that are testing GPL code must be moved to separate unit tests projects.
  • There should be a separate project containing any GPL'd assemblies.

cesarsouza added a commit that referenced this issue Apr 14, 2015
All unit test projects have been disentangled and now their references are restricted to same references that their target tested projects also have. A few implementations have been moved between projects, but compatibility should not have been broken. Some work also has been put in place to prepare for the AForge.NET merge.

Merge branch 'GH-24' into development
@cesarsouza
Copy link
Member Author

  • Now each unit test project should depend only on the assembly being tested and its dependencies.
  • Unit tests for MachineLearning.GPL have been moved to a separate unit test project (Accord.Tests.MachineLearning.GPL), and unit tests for Math.Noncommercial have been moved to Accord.Tests.Math.Noncommercial
  • A separate solution file (named Accord.NET (LGPL-only) has been created to hold only strictly LGPL projects).

@CatchemAL
Copy link
Collaborator

Is branch GH-24 active? Propose delete?

@cesarsouza
Copy link
Member Author

No, it is not active, it can be deleted!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants