Fix: Add a 'min' function to work with go1.18.1 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechSolomon
added a commit
that referenced
this pull request
Jul 12, 2024
* Released data diode system information (#53) * docs: build requirements for `make` * fix: match MQTT client ID * Fix: Add a 'min' function to work with go1.18.1, the default on Ubuntu 22.04. (#54) * refactor: continuous outbound MQTT topic structure * bump: project requirements * docs: resolve formatting issues with markdownlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 22.04, the default go version is 1.18.1, which doesn't have "min" in the standard library.
The usual fix is to add a local definition, which I've done here. Everything else compiles, and seems to work fine as far as I can test.