Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create_timepoint] Success swal appears even on failure #9358

Open
skarya22 opened this issue Sep 24, 2024 · 0 comments · May be fixed by #9502
Open

[create_timepoint] Success swal appears even on failure #9358

skarya22 opened this issue Sep 24, 2024 · 0 comments · May be fixed by #9502
Assignees
Labels
Category: Bug PR or issue that aims to report or fix a bug

Comments

@skarya22
Copy link
Contributor

Describe the bug

  • Even when an error occurs, the success swal appears on submit in create_timepoint.

To Reproduce

  1. Break the create_timepoint php code if not already broken. (If [Create_Timepoint] Failure on submit #9357 was merged)
  2. Go to a Access Profile > select a candidate > Create Timepoint
  3. Enter valid information
  4. Press submit
  5. See error

What did you expect to happen?

  • Since there was an error, there should be an error swal, not a success one.
@skarya22 skarya22 added the Category: Bug PR or issue that aims to report or fix a bug label Sep 24, 2024
@victori444 victori444 linked a pull request Dec 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants