Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redirect options as columns to the Bundles tab #41

Open
AllieRays opened this issue Feb 7, 2020 · 3 comments
Open

Add Redirect options as columns to the Bundles tab #41

AllieRays opened this issue Feb 7, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@AllieRays
Copy link

Description
There are content types that never should be displayed with its own page, like an image media entity that's displayed in a carousel. Rabbit Hole can prevent this node from being accessible on its own page with the following options

  • Deliver an access denied page.
  • Deliver a page not found page.
  • Issue a page redirect to any path or external url.
  • Or simply display the entity (regular behavior).

I think this should be a standard and specified in the Drupal Spec tool. I made a copy of the Drupal spec tool excel book with the updates I think should be added.
https://docs.google.com/spreadsheets/d/1muqPOBLFwr_PySl5OIbcWhrObGzs0yCamrJEGm_pBV8/edit?usp=sharing

Implementation

Columns that would need to be added to the Bundles tab.

Column Redirect Behavior Redirect Override Redirect Path
note Redirect Module is Enabled Redirect Module is Enabled. If page redirect is selected, then allow these settings to be overridden for individual entities. If this is checked, users with the Administer Rabbit Hole settings for Content type permission will be able to override these settings for individual entities. Rabbit Hole is enabled. This is the path where nodes should be redirected. A good default would be /front.
data validation Page Redirect, Page not found, Display the page, Access denied y, n n/a
@AllieRays AllieRays changed the title Add Redirect option as a column Add Redirect option as columns to the Bundles tab Feb 7, 2020
@AllieRays AllieRays changed the title Add Redirect option as columns to the Bundles tab Add Redirect options as columns to the Bundles tab Feb 7, 2020
@AllieRays
Copy link
Author

As discussed, I made an issue with the lightning core module to add Rabbit hole into the lighting distro.
https://www.drupal.org/project/lightning_core/issues/3112048

@TravisCarden TravisCarden added the enhancement New feature or request label Feb 10, 2020
@TravisCarden
Copy link
Contributor

Thanks, @AllieRays. As I said when we discussed it, I support this, and I'll accept it if any of the following criteria are met:

  • The module is included in Lightning or Drupal core
  • PS makes it an official best practices recommendation
  • A significant proportion of the Drupal community adopts the solution

(I should document that standard somewhere.)

Please let me know if you determine that any of those conditions attain. I'll bring your Lightning issue to the attention of the team.

@TravisCarden
Copy link
Contributor

TravisCarden commented Feb 10, 2020

I brought it up to the Lightning team, @AllieRays, and they said they'd rather see this functionality go into Drupal core. Here's a d.o issue I created a couple of years ago which has a lot of overlap with which got a flash of attention at the time: Make the features of content, taxonomy, and blocks available à la carte [#2939529]. I would encourage you to file another issue to include Rabbit hole functionality in core and cross-link those issues. In the meantime, I would love to see PS adopt this as a best practice. If you'd like to start a conversation (with the tech leads?) I would be happy to weight in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants