Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check S3 before building. #2

Closed
jamesiarmes opened this issue Mar 9, 2016 · 1 comment
Closed

Check S3 before building. #2

jamesiarmes opened this issue Mar 9, 2016 · 1 comment

Comments

@jamesiarmes
Copy link
Contributor

Issue by glennpratt
Tuesday Oct 20, 2015 at 23:05 GMT
Originally opened as https://github.com/acquia/cloud-moonshot/issues/14


Depends on #12 to be useful, with the project supplying a reliable version id that doesn't always rely on timestamp.

For deploy-code, check S3 before building and skip if it already does.

There should be a way to overwrite a build if somehow a bad build is pushed, probably build-code.

Could improve the "dev quickstart" time.

@jamesiarmes
Copy link
Contributor Author

Comment by askreet
Wednesday Oct 21, 2015 at 15:19 GMT


One blocker here is the ArtifactRepository's store hook isn't invoked until a build is done locally. You can do a deploy-version without doing a build today however I think the improvement in quickstart you're talking about comes from the creation of a stack not doing a full deploy-code, but instead using a deploy-version with a version built from master.

I think we need another pluggable component here, but I'm not sure what it is. Something like the deploy-code action asking a VersionProvider for the version number, then asking the ArtifactRepository if it's found. If not, it calls the BuildMechanism, then the ArtifactRepositories store action, before finally calling the DeploymentMechanism. If it does exist, it can skip directly to the DeploymentMechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant