Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Tests for New Chain-Specific SpokePools #822

Open
11 tasks
Dhruv-Varshney-developer opened this issue Dec 25, 2024 · 1 comment
Open
11 tasks

Comments

@Dhruv-Varshney-developer
Copy link

Dhruv-Varshney-developer commented Dec 25, 2024

Some chain-specific SpokePools lack tests, which could lead to potential issues, as these functionalities may not have been validated thoroughly.

The SpokePool files are located in the contracts/contracts directory, while the tests should be added in the test/evm/hardhat/chain-specific-spokepools directory.

Tests need to be added for the following spoke pools:

  • AlephZero_SpokePool
  • Base_SpokePool
  • Blast_SpokePool
  • Boba_SpokePool
  • Ink_SpokePool
  • Lisk_SpokePool
  • Mode_SpokePool
  • Ovm_SpokePool
  • Redstone_SpokePool
  • WorldChain_SpokePool
  • Zora_SpokePool

Impact

  • Lack of automated testing increases the risk of undetected bugs
  • Makes it harder to verify contract behaviour across different chain implementations
  • Could affect the reliability of cross-chain operations

Proposed Solution

Add comprehensive test files for each missing spoke pool implementation following existing test patterns from files like Arbitrum_SpokePool.ts and Ethereum_SpokePool.ts.

Tasks

  1. Create test files in test/evm/hardhat/chain-specific-spokepools for each listed spoke pool.
  2. Implement standard test cases covering core functionality.
  3. Add chain-specific test cases where needed.
@Dhruv-Varshney-developer
Copy link
Author

Hi @mrice32 @nicholaspai @chrismaree @pxrl,
I'm working on adding tests for the missing SpokePool implementations. I've created PR #818 that adds test coverage for Base_SpokePool, and I plan to work on tests for other chains as well.

Let me know your thoughts here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant