You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some chain-specific SpokePools lack tests, which could lead to potential issues, as these functionalities may not have been validated thoroughly.
The SpokePool files are located in the contracts/contracts directory, while the tests should be added in the test/evm/hardhat/chain-specific-spokepools directory.
Tests need to be added for the following spoke pools:
AlephZero_SpokePool
Base_SpokePool
Blast_SpokePool
Boba_SpokePool
Ink_SpokePool
Lisk_SpokePool
Mode_SpokePool
Ovm_SpokePool
Redstone_SpokePool
WorldChain_SpokePool
Zora_SpokePool
Impact
Lack of automated testing increases the risk of undetected bugs
Makes it harder to verify contract behaviour across different chain implementations
Could affect the reliability of cross-chain operations
Proposed Solution
Add comprehensive test files for each missing spoke pool implementation following existing test patterns from files like Arbitrum_SpokePool.ts and Ethereum_SpokePool.ts.
Tasks
Create test files in test/evm/hardhat/chain-specific-spokepools for each listed spoke pool.
Implement standard test cases covering core functionality.
Add chain-specific test cases where needed.
The text was updated successfully, but these errors were encountered:
Hi @mrice32@nicholaspai@chrismaree@pxrl,
I'm working on adding tests for the missing SpokePool implementations. I've created PR #818 that adds test coverage for Base_SpokePool, and I plan to work on tests for other chains as well.
Some chain-specific SpokePools lack tests, which could lead to potential issues, as these functionalities may not have been validated thoroughly.
The SpokePool files are located in the
contracts/contracts
directory, while the tests should be added in thetest/evm/hardhat/chain-specific-spokepools
directory.Tests need to be added for the following spoke pools:
Impact
Proposed Solution
Add comprehensive test files for each missing spoke pool implementation following existing test patterns from files like
Arbitrum_SpokePool.ts
andEthereum_SpokePool.ts
.Tasks
test/evm/hardhat/chain-specific-spokepools
for each listed spoke pool.The text was updated successfully, but these errors were encountered: