You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Is this related to the actions-rs Actions?
If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.521000.bestmunity
Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.
Motivation
Generally, the rustup tool is stable across releases. However, the 1.25.0 release broke our GitHub Actions CI (rust-lang/rustup#3029). Since this is CI, any failures get in the critical path of our development workflow, so it's crucial to be able to roll out a fix as soon as possible. Pinning the rustup version to 1.24.3 should have been able to fix this problem, but there does not appear to be an easy way to do this in actions-rs.
Additionally, I am unsure of exactly how this works when there are multiple actions-rs steps in the same workflow. If one of them has the rustup version specified, and another has a different or missing rustup version, how do we determine which rustup version to install?
Do the checklist before filing an issue:
actions-rs
Actions?If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.521000.bestmunity
Motivation
Generally, the
rustup
tool is stable across releases. However, the 1.25.0 release broke our GitHub Actions CI (rust-lang/rustup#3029). Since this is CI, any failures get in the critical path of our development workflow, so it's crucial to be able to roll out a fix as soon as possible. Pinning the rustup version to 1.24.3 should have been able to fix this problem, but there does not appear to be an easy way to do this in actions-rs.Workflow example
Additional context
I think the change would go here:
core/src/commands/rustup.ts
Line 50 in 4487ec1
Currently it always installs from a fixed path:
Instead, we would need to install from a path such as:
Additionally, I am unsure of exactly how this works when there are multiple actions-rs steps in the same workflow. If one of them has the rustup version specified, and another has a different or missing rustup version, how do we determine which rustup version to install?
CC @Manishearth @aethanyc @robertbastian
The text was updated successfully, but these errors were encountered: