Get it working #2
Conversation
* Get it working * Required token * Logging * Debug * Debug * Correct logging * No setNeutral * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * working * logging * logging * logging * logging * logging * logging * logging * logging * logging * logging * debug * debug
|
The readme needs an example of how to use the action. |
|
Done |
|
I think I've responded to all feedback, let me know if you think this is good to merge. |
| description: 'Input to use' | ||
| default: 'world' | ||
| inputs: | ||
| repo-token: |
There was a problem hiding this comment.
Nit: Are we going with a pattern of abbreviating names? repo-token vs. repository-token. Personal preference is longer version.
There was a problem hiding this comment.
repo-token is currently the standard across the board. I'm not inclined to change it at this point since it affects other actions as well (plus I just prefer repo haha)
| throw new Error('Internal error, no sender provided by GitHub'); | ||
| } | ||
| const sender: string = context.payload.sender!.login; | ||
| const issue: {owner: string; repo: string; number: number} = context.issue; |
There was a problem hiding this comment.
We can fix in a future PR but it's a bit confusing to call both "issue" and "pr" an "issue"
There was a problem hiding this comment.
I agree, that's how octokit does it though. I think I agree that its worth changing though because its still confusing, but also that it can be done in a future PR!
Should work on issues and pull requests. Allows you to display a message on the first one of either.