Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable scripts #959

Open
jksolbakken opened this issue Feb 13, 2024 · 2 comments
Open

Disable scripts #959

jksolbakken opened this issue Feb 13, 2024 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@jksolbakken
Copy link

Description:
It would be nice to be able to configure npm to ignore pre and postinstall scripts.

Justification:
Pre/postinstall scripts are a potential security problem.

Are you willing to submit a PR?
Yes, see #955
@jksolbakken jksolbakken added feature request New feature or request to improve the current logic needs triage labels Feb 13, 2024
@aparnajyothi-y
Copy link
Contributor

Hello @jksolbakken, Thank you for creating this feature request and we will get back to you once we have some feedback :)

@janbrasna
Copy link

Some example uses as https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#use-private-packages give good reasoning why, but most importantly it also shows how to run the postinstalls via rebuild in a next step without the secrets. I like that approach a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janbrasna @jksolbakken @aparnajyothi-y