start #1

bryanmacfarlane · 2019-05-31T04:32:01Z

Starting with code from Danny and I

See docs/contributors for details on what's checked in and not

toolkit is added as tgz files for now since not public yet

bryanmacfarlane · 2019-05-31T04:33:03Z

more work to do and tests needed. getting directional feedback early

damccorm · 2019-05-31T05:45:21Z

.gitignore

@@ -0,0 +1,6 @@
+# runtime dependencies are checked in
+# dev dependencies are *not* checked in


Doesn't have to be part of this initial PR, but maybe we should just webpack as part of our build process. Then we can just ignore node modules

Note also - this also doesn't really work to not check in dev dependencies. While this doesn't check in the top level dev-deps, nested dependencies will still get checked in. For example, Prettier alone has ~60 dependencies all of which get checked in (not to mention the dependencies of those dependencies).

I think webpack is probably the best path forward here.

Are we doing this to avoid having to npm install the production dependencies of this tool? If so, there are a few options for vendoring in dependencies that we already use at GitHub. If you can give me a sense of the goal with this, I can advise.

The runner will run the action from the github graph at runtime per the execution model. That is, it will get the targz of that ref and run it.

Dependencies are vendored in as you noted.

@damccorm - regarding dev dependencies, you can use npm prune before you publish (push).

Oh cool - didn't know about npm prune. It looks like that handles all devDependencies though, so we probably don't need those listed in gitignore. It also might be good to enforce that with something like husky

See #5 proposing using husky

damccorm · 2019-06-04T18:07:48Z

src/installer.ts

+      throw new Error('Expected Agent.TempDirectory to be set');
+    }
+
+    let _7zPath = path.join(__dirname, '7zr.exe');


Right now, we're not doing anything with this. With that said, we do need to bundle our own version of 7zr.exe to avoid path-too-long issues (I was running into them installing node 10 with this code). I'll need to add support for that in actions/tool-kit/tool-cache as well.

I fixed that in my tool-cache PR and here as well.

damccorm · 2019-06-04T18:13:58Z

src/installer.ts

+  try {
+    downloadPath = await tc.downloadTool(downloadUrl);
+  } catch (err) {
+    if (err['httpStatusCode'] && err['httpStatusCode'] === '404') {


Right now we're not returning the status code like this so this will fail. I should update actions/toolkit/tool-cache to do this

Added this to my tool-cache PR, not packed into this one yet though so tests will still fail for now.

Once the change from this comment is implemented in tool-cache, you can check err instanceof HTTPError && err.httpStatusCode === 404 (I think it's actually a number, but not 100% on that).

Although I think you can actually cheat here, since err is always any, I believe. You can just check err.httpStatusCode === 404.

Updated to consume the more recent tool-cache and this works now. Went with
err instanceof HTTPError && err.httpStatusCode == 404
I thought loose equality to a number was best here just in case this ends up getting attached as a string down the line for some reason

Add testing

jclem

Directionally, looks fine. As far as structuring the package is concerned, I have a few questions:

I don't think we need to check in the compiled code, do we? We can build the TypeScript and push the JS output to npm without actually checking the output into the repository (npm doesn't actually understand git, .gitignore, etc).
Is there a reason we vendor in these dependencies instead of installing them?

jclem · 2019-06-04T21:35:22Z

.gitignore

@@ -0,0 +1,6 @@
+# runtime dependencies are checked in
+# dev dependencies are *not* checked in


Are we doing this to avoid having to npm install the production dependencies of this tool? If so, there are a few options for vendoring in dependencies that we already use at GitHub. If you can give me a sense of the goal with this, I can advise.

bryanmacfarlane · 2019-06-04T22:05:48Z

@jclem - yes, we need to check in the compiled code since actions are run from the github graph. The runner gets the action targz at the ref and runs it. That's also the reason runtime dependencies are vendored.

damccorm · 2019-06-05T19:14:13Z

Merging since it sounds like we're on the same page for this right now. We can reopen discussion as appropriate

initial version of cli

Better paths

start

eac9260

damccorm reviewed May 31, 2019

View reviewed changes

damccorm reviewed Jun 4, 2019

View reviewed changes

Danny McCormick added 2 commits June 4, 2019 16:00

Add tests

48c6283

Clean up changes

d0b97fb

damccorm mentioned this pull request Jun 4, 2019

Add testing #3

Merged

Merge pull request #3 from actions/users/damccorm/testing

d83862c

Add testing

jclem reviewed Jun 4, 2019

View reviewed changes

Danny McCormick added 2 commits June 5, 2019 11:22

Update tool-cache we consume

d7b6952

Use custom 7zr

a78e5a5

damccorm merged commit 3b7fa72 into master Jun 5, 2019

damccorm deleted the features/start branch June 7, 2019 19:22

krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023

Merge pull request actions#1 from akamai/initial_code

2cdbcff

initial version of cli

adilhusain-s mentioned this pull request Oct 3, 2023

adding support for linux ppc64le #862

Open

2 tasks

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023

Merge pull request actions#1 from EndBug/better-paths

782b6b1

Better paths

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

start #1

start #1

bryanmacfarlane commented May 31, 2019

bryanmacfarlane commented May 31, 2019

damccorm May 31, 2019

damccorm Jun 4, 2019 •

edited

Loading

jclem Jun 4, 2019

bryanmacfarlane Jun 4, 2019

damccorm Jun 5, 2019

damccorm Jun 5, 2019

damccorm Jun 4, 2019

damccorm Jun 5, 2019

damccorm Jun 4, 2019

damccorm Jun 4, 2019

jclem Jun 4, 2019 •

edited

Loading

jclem Jun 4, 2019

damccorm Jun 5, 2019

jclem left a comment

jclem Jun 4, 2019

bryanmacfarlane commented Jun 4, 2019

damccorm commented Jun 5, 2019

		@@ -0,0 +1,6 @@
		# runtime dependencies are checked in
		# dev dependencies are not checked in

start #1

start #1

Conversation

bryanmacfarlane commented May 31, 2019

bryanmacfarlane commented May 31, 2019

Choose a reason for hiding this comment

damccorm Jun 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jclem Jun 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jclem left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bryanmacfarlane commented Jun 4, 2019

damccorm commented Jun 5, 2019

damccorm Jun 4, 2019 •

edited

Loading

jclem Jun 4, 2019 •

edited

Loading