Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm-version option #247

Closed
wants to merge 1 commit into from
Closed

Add npm-version option #247

wants to merge 1 commit into from

Conversation

frbuceta
Copy link

This change adds an option which allows to install a different version of NPM

@mattstrayer
Copy link

This would be a very welcomed feature. Can we get this out the door?

@mellis481
Copy link

@frbuceta Are you able to see this PR through please? Would be great to get this in.

Copy link

@pierresisson pierresisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sztadii
Copy link

sztadii commented Jul 21, 2022

@marko-zivic-93 @brcrista It looks like the forked repo does not exist, so we can not resolve the conflicts. Should we close the PR?

@brcrista
Copy link
Contributor

@sztadii yes, we'll have to do that to make progress.

Looks like a useful feature. But rather than adding a separate input, perhaps we should just support engines.npm as we are with engines.node: #485

@brcrista brcrista closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants