Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation around architecture field to include arm64 #966

Closed
5 tasks done
michael-myers opened this issue Oct 21, 2024 · 3 comments
Closed
5 tasks done
Assignees
Labels
bug Something isn't working

Comments

@michael-myers
Copy link

Description:
In the setup-python README and code comments in action.yml the architecture field only mentions x86 and x64, but elsewhere, GitHub Actions documentation says arm64 is a supported architecture across all GitHub-provided Actions. It seems like that is true, but the documentation here hasn't been updated.

If not supplying the architecture field, will setup-python still default to x64 even on an arm64 host? Because it looks like it will default to the arch of the host OS.

Action version:
v5.2.0

Platform:

  • Ubuntu
  • macOS
  • Windows

It seems GitHub Actions provides hosted arm64 runners for all three platforms.

Runner type:

  • Hosted
  • Self-hosted

Tools version:
n/a, this is about documentation

Repro steps:
n/a, this is about documentation

Expected behavior:
n/a, this is about documentation

Actual behavior:
n/a, this is about documentation

@priyagupta108
Copy link
Contributor

Hi @michael-myers 👋,
Thank you for pointing out the discrepancy in the documentation regarding the architecture field.
To clarify, when the architecture field is not specified, the action defaults to the host OS architecture, which includes arm64 for arm64 hosts.
We will update the documentation accordingly. If you have any additional insights or spot other documentation gaps, please let us know.

@priya-kinthali
Copy link
Contributor

Hello @michael-myers 👋,
We have recently merged PR #965, which updates the README and action.yml to include arm64 support in the architecture field.
Please check the updated documentation. We will now proceed to close this issue. If you have any further questions or concerns, please feel free to let us know.
Thank you!

@michael-myers
Copy link
Author

Looks good to me, and thank you for the quick resolution! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants