Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale bot takes some of its prior changes as activity that resets the stale clock #842

Closed
ghogen opened this issue Oct 7, 2022 · 2 comments
Labels
bug Something isn't working Stale

Comments

@ghogen
Copy link

ghogen commented Oct 7, 2022

Describe your issue

We're looking at the newer activity of the bot and still seeing that the bot's own prior activity (adding comments, adding or removing labels) is still counted as activity on the issue. This is unrelated to the timestamp comparison problem, but it matches the original title of issue 795. I'm using "v5" which should pick up the 5.2.0 which I think should have the update. Here's an issue that we processed through the latest version and it decides that the "last updated date" is 9/15/2022 which is when it removed the stale label. The last real update was back in March.

image

https://github.com/MicrosoftDocs/visualstudio-docs/issues/6077
We have two other examples all with the same problem:
https://github.com/MicrosoftDocs/visualstudio-docs/issues/6678 - bot takes its own update on 8/4 as last activity date. Last non-bot update was January, so it should be marked stale, but it is not due to the bot update on 8/4.

Expectation: any activity by the bot (comments, adding/removing labels, etc.) should not be counted as update activity that resets the stale clock.

Your stale action configuration

name: close-stale-issues

on:
  schedule:
    - cron: "0 0 * * 4"
  workflow_dispatch:

permissions:
  contents: read

jobs:
  stale:
    permissions:
      issues: write  # for actions/stale to close stale issues
      pull-requests: write  # for actions/stale to close stale PRs
    runs-on: ubuntu-latest
    steps:
      - uses: actions/stale@v6
        with:
          repo-token: ${{ secrets.GITHUB_TOKEN }}
          stale-issue-message: 'Thanks for sharing your feedback. We apologize for our delayed response. Due to the sheer volume of feedback in our repo, we have decided to prioritize the newest issues and are automatically closing our oldest issues with an Issues bot. If you believe your feedback is still actionable, then either respond directly in this issue or open a new documentation issue and we’ll review. If no activity occurs in the next 14 days, this issue will be closed.'
          close-issue-message: 'This issue is closed. If you feel this issue has been closed in error, please submit a new comment on the issue, and we will review it.'
          stale-issue-label: 'stale'
          close-issue-label: 'auto-close'
          exempt-issue-labels: 'exempt'
          remove-stale-when-updated: true
          days-before-close: 14
          days-before-issue-stale: 180
          days-before-pr-stale: -1
          operations-per-run: 500

Further context

Related to #795

@ghogen ghogen added the bug Something isn't working label Oct 7, 2022
@ghogen
Copy link
Author

ghogen commented Oct 7, 2022

It's possible that this only occurs in issues that were affected by previous bugs, as the problems are all in issues where stale label was erroneously removed by a prior version of the bot.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Nov 14, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants
@ghogen and others