Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node grouping with Rails 5 doesn't work #807

Closed
tbaba opened this issue Jun 26, 2017 · 0 comments
Closed

Node grouping with Rails 5 doesn't work #807

tbaba opened this issue Jun 26, 2017 · 0 comments

Comments

@tbaba
Copy link

tbaba commented Jun 26, 2017

Hello.
I got a one of error in ransack/adapters/active_record/context.rb.
My application uses build_grouping method with Ransack#search, and this was clearly working with Rails 5.0. But when i try Rails 5.1, this feature is broken.
Comparing the method and caller logic, ransack gives 7 arguments, but activerecord expects 5.

            join_constraints = association.join_constraints(
              parent.table,
              parent.base_klass,
              association,
              Arel::Nodes::OuterJoin,
              association.tables,
              reflection.scope_chain,
              reflection.chain
            )
        def join_constraints(foreign_table, foreign_klass, join_type, tables, chain)

How do i resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant